Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.12.0 -- Add Group Aliases #116

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Release 2.12.0 -- Add Group Aliases #116

merged 12 commits into from
Nov 14, 2024

Conversation

mtompset
Copy link
Contributor

Add

  • delete, insert, and listGroupsAliases for Group Alias functionality
  • tests for the Group Alias functionality

Change (non-breaking)

  • renamed variable names with $_
  • PSR-12 clean up on various files

Fix

  • id generation in Group data

@mtompset mtompset requested a review from a team November 14, 2024 16:54
@mtompset mtompset self-assigned this Nov 14, 2024
@mtompset mtompset requested review from briskt, forevermatt, jason-jackson and hobbitronics and removed request for a team November 14, 2024 16:54
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments that I feel decrease readability and maintainability (more in the 2nd case than the first).

SilMock/Google/Service/Directory/UsersResource.php Outdated Show resolved Hide resolved
SilMock/tests/Sqlite/SqliteUtilsTest.php Outdated Show resolved Hide resolved
@mtompset mtompset merged commit 3f2250a into main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants